Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Payments: Handle empty strings as nulls in Payments data #2943

Closed
10 of 11 tasks
lauriemerrell opened this issue Sep 18, 2023 · 0 comments · Fixed by #2953
Closed
10 of 11 tasks

Payments: Handle empty strings as nulls in Payments data #2943

lauriemerrell opened this issue Sep 18, 2023 · 0 comments · Fixed by #2953
Assignees
@charlie-costanzo

Comments

@lauriemerrell
Copy link
Contributor

lauriemerrell commented Sep 18, 2023 •
edited by charlie-costanzo
Loading

In the investigation of refunds data, I discovered that several payments staging tables include cases where a column contains an empty string (""). These columns are very problematic because they are effectively null but they will not be returned by queries on column IS NULL. We have a dbt macro trim_make_empty_string_null designed to convert such cases (and also cases where a string is only whitespace) to nulls. We should apply this macro on all string columns in the Payments data:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charlie-costanzo charlie-costanzo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

handle empty strings as nulls in littlepay staging tables cal-itp/data-infra
2 participants
@charlie-costanzo @lauriemerrell