Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust handling of enrollment when customer already exists in group #1803

Closed
thekaveman opened this issue Dec 1, 2023 · 1 comment · Fixed by #1804
Closed

Adjust handling of enrollment when customer already exists in group #1803

thekaveman opened this issue Dec 1, 2023 · 1 comment · Fixed by #1804
Assignees
Labels
bug Something isn't working

Comments

@thekaveman
Copy link
Member

thekaveman commented Dec 1, 2023

Our payment processor uses a 500 error response to indicate that a customer is already enrolled in a group.

This is not an actual problem for Benefits, so we have code that handles the response and returns a success to the user.

The error handling is brittle, relying to some degree on the returned error message. This message has now changed, thus our handling is broken.

To Reproduce

Steps to reproduce the behavior:

  1. Go to test
  2. Verify as a senior with SacRT
  3. Enroll a card
  4. Do 2-3 again with the same card --> BOOM

Expected behavior

Attempting to re-enroll with the same card should not cause an error for the end user.

Additional context

New error message from the logs looks like:

Customer xxxx already exists in group yyyy

The old one looked more like:

Duplicate customer xxxxx...
@thekaveman thekaveman added the bug Something isn't working label Dec 1, 2023
@thekaveman thekaveman self-assigned this Dec 1, 2023
@thekaveman thekaveman moved this from Todo to In Progress in Digital Services Dec 1, 2023
@cal-itp-sentry
Copy link

cal-itp-sentry bot commented Dec 1, 2023

Sentry issue: BENEFITS-48

@cal-itp cal-itp deleted a comment from cal-itp-sentry bot Dec 1, 2023
@thekaveman thekaveman moved this from In Progress to In Review in Digital Services Dec 1, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Digital Services Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant