Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different state reported for Sarif issues when successful and failed #477

Closed
pascalberger opened this issue Jul 19, 2024 · 1 comment · Fixed by #478
Closed

Different state reported for Sarif issues when successful and failed #477

pascalberger opened this issue Jul 19, 2024 · 1 comment · Fixed by #478
Labels
Milestone

Comments

@pascalberger
Copy link
Member

When issues from SARIF provider , they use a different state name if the state is successful or failed:

  • Successful: Issues-SARIF
  • Failed: Issues-<TOOLNAME>

The reason for this is, that the SARIF issue provider will use the tool name reported in the SARIF file as issue provider name on issues, which is not considered when no issue is reported.

@pascalberger
Copy link
Member Author

Cake.Issues.Sarif introduces a new setting SarifIssuesSettings.UseToolNameAsIssueProviderName which can be used to enforce a consistent issue provider name.

See cake-contrib/Cake.Issues#686 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant