Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HtmlInline_AzurePipelines and MHtml shares the same numeric value #2439

Closed
devlead opened this issue Jan 9, 2019 · 0 comments · Fixed by #2450
Closed

HtmlInline_AzurePipelines and MHtml shares the same numeric value #2439

devlead opened this issue Jan 9, 2019 · 0 comments · Fixed by #2450
Labels
Bug
Milestone
v0.33.0

Comments

@devlead
Copy link
Member

devlead commented Jan 9, 2019

As raised by @dolifer in 73e1400#r31873452

HtmlInline_AzurePipelines and MHtml shares the same numeric value, which causes incorrect output, when inline HTML is expected :(

This is a bug and needs to be corrected, affected lines

cake/src/Cake.Common/Tools/ReportGenerator/ReportGeneratorReportType.cs

Line 75 in 73e1400

HtmlInline_AzurePipelines = 13,

cake/src/Cake.Common/Tools/ReportGenerator/ReportGeneratorReportType.cs

Line 80 in 73e1400

MHtml = 13,

Values need to be unique, propose MHtml gets put at end after

cake/src/Cake.Common/Tools/ReportGenerator/ReportGeneratorReportType.cs

Line 85 in 73e1400

PngChart = 14

with value 15.

Marking this as up for grabs / help wanted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
v0.33.0
Development

Successfully merging a pull request may close this issue.

GH2439: Fix the numeric values of the enumeration yansklyarenko/cake
1 participant
@devlead