Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging the sim #9

Open
belgiumkansas opened this issue Jun 9, 2020 · 3 comments
Open

packaging the sim #9

belgiumkansas opened this issue Jun 9, 2020 · 3 comments
Labels
backlog enhancement New feature or request question Further information is requested

Comments

@belgiumkansas
Copy link
Contributor

belgiumkansas commented Jun 9, 2020

propose making cairo_sim into a sub-package called core_sim and as separate sub-packages the openai_env and planing.
Thus making cairo_sim the top level package name and allowing for uploading of project to the python packaging index
ie.

from cairo_sim.core_sim.simulator import Simulator
from cairo_sim.planner.collision import self_collision_test

@belgiumkansas belgiumkansas added enhancement New feature or request question Further information is requested labels Jun 9, 2020
@belgiumkansas
Copy link
Contributor Author

it makes things more verbose but also more flexible to expanding and organizing features. looking for thoughts

@cmuell89
Copy link
Contributor

cmuell89 commented Jun 9, 2020

This could fairly easily be done with namespacing and as is the import calls are as you've written. I don't really see much motivation to upload to PyPI at the moment? The sim, planner, and openai stuff will be in seriously flux for the next few months.

I propose we bring it up in a month's time to see where we stand? Thoughts?

@belgiumkansas
Copy link
Contributor Author

Yea we can do that. sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants