Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor peft module to take out common peft config functionality #163

Closed
1 task done
gkumbhat opened this issue Aug 31, 2023 · 2 comments
Closed
1 task done

Refactor peft module to take out common peft config functionality #163

gkumbhat opened this issue Aug 31, 2023 · 2 comments
Assignees
@rawkintrevo
Milestone
Add support for LoRA

Comments

@gkumbhat
Copy link
Collaborator

gkumbhat commented Aug 31, 2023 •
edited by alex-jw-brooks
Loading

Description

In order to re-use peft configuration in fine-tuning modules, we want to take out the common peft configuration logic to toolkit/text_generation so that we can reuse these with couple of function calls from both of our tuning functions.

This includes, move of:

  1. allowed_tuning_init_methods
  2. TuningType
  3. peft config creation and its usage here

Discussion

Provide detailed discussion here

Acceptance Criteria

  • Unit tests cover new/changed code
@gkumbhat gkumbhat added this to the Add support for LoRA milestone Aug 31, 2023
@chakrn chakrn moved this from ToDo to In Progress in caikit ecosystem Sep 5, 2023
@gkumbhat gkumbhat mentioned this issue Sep 5, 2023
Open
4 tasks
@rawkintrevo rawkintrevo linked a pull request Sep 7, 2023 that will close this issue
[caikit-nlp-163] Refactor peft module to take out common peft config functionality #174
Closed
@gkumbhat gkumbhat moved this from In Progress to Ready for Review in caikit ecosystem Sep 12, 2023
@chakrn
Copy link
Collaborator

chakrn commented Sep 19, 2023

@alex-jw-brooks says I can close this

@chakrn chakrn moved this from Ready for Review to Closed in caikit ecosystem Sep 19, 2023
@chakrn chakrn closed this as completed Sep 19, 2023
@alex-jw-brooks
Copy link
Collaborator

Link to rebase PR that was merged: #197

@ibm-peach-fish ibm-peach-fish mentioned this issue Sep 28, 2023
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rawkintrevo rawkintrevo

Labels
None yet
Projects
caikit ecosystem
Status: Closed
Milestone
Add support for LoRA
Development

Successfully merging a pull request may close this issue.

[caikit-nlp-163] Refactor peft module to take out common peft config functionality
4 participants
@rawkintrevo @gkumbhat @alex-jw-brooks @chakrn