Skip to content
This repository has been archived by the owner on Nov 28, 2023. It is now read-only.

Drought nav does not update when edited in WP admin #126

Closed
thepegisin opened this issue Sep 29, 2021 · 12 comments
Closed

Drought nav does not update when edited in WP admin #126

thepegisin opened this issue Sep 29, 2021 · 12 comments
Assignees
Labels
bug Something isn't working Headless publishing P2 Tech Technology and Development Track

Comments

@thepegisin
Copy link

thepegisin commented Sep 29, 2021

@chachasikes showed me how to update the navigation menu in the WP admin (Appearance > Menus). But while the changes I made appear to be saved in WP, they don't appear on the website. This is affecting our ability to link in a new page to the nav.

See Slack thread on this: https://cadotgov.slack.com/archives/C026VJB8Q1G/p1632877211125600

@thepegisin thepegisin added bug Something isn't working Headless publishing P0 Tech Technology and Development Track labels Sep 29, 2021
@aaronhans
Copy link
Contributor

Drought frontend build is pulling menu structure here https://github.com/cagov/drought.ca.gov/blob/main/src/templates/_data/menus.js#L4

@abquirarte
Copy link

@carterm
Copy link
Contributor

carterm commented Oct 1, 2021

Issue added...
cagov/wordpress-to-github#50

@jbum
Copy link
Contributor

jbum commented Oct 1, 2021

@jbum jbum removed their assignment Oct 1, 2021
@xjensen xjensen removed their assignment Oct 5, 2021
@chachasikes
Copy link
Contributor

Looked at the code - the menus data needs to be connected to wordpress-to-github.

This would be a good task for cross-training. (We will learn a lot in the process.)

Assigning to @xjensen.

@chachasikes
Copy link
Contributor

@xjensen: We will go over the code in our code review next week. Maybe after that you can take a look to try to add an endpoint to the system.

@chachasikes
Copy link
Contributor

Unassigning @carterm - Carter - after our code review next week, can you help Jon succeed with this task?

Are there things Jon should know about adding the menu?

@xjensen
Copy link
Collaborator

xjensen commented Oct 22, 2021

It was working before, as seen in the Development environment. I figured we were waiting for a real-world reason to test it out.

If the config for the menu API URL is going into a different file (a good idea), then I'll need guidance on where it should go.

@wrendo wrendo removed the P0 label Oct 23, 2021
@chachasikes chachasikes added the P2 label Oct 23, 2021
@aaronhans
Copy link
Contributor

depends on cagov/wordpress-to-github#50

@xjensen
Copy link
Collaborator

xjensen commented Nov 8, 2021

Quick note. Menu work within the wordpress-to-github module has been completed. In short, this set of changes to wordpress-to-github will help trigger site rebuilds whenever a change is made to a menu within Wordpress.

However, deploying this set of changes into live service is on-hold. We're working on putting processes in place around how we deploy changes to publishing systems. These processes will help us ensure everyone is properly notified and nothing breaks.

Once the above wordpress-to-github changes are deployed, we'll need to do some minor Drought work here to consume the new menu data. That's the next step, stay tuned.

@thepegisin
Copy link
Author

Revisiting this. I need to add a new link to the top nav: Water-saving tips. Made the change in WP menu, but it's not live. How do we make it live? @xjensen

@thepegisin
Copy link
Author

Per Jon: "Just takes a few minutes. The menu updates are not pushed out to the site immediately; they need to be pulled when the wordpress-to-github polling service runs every few minutes."

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Headless publishing P2 Tech Technology and Development Track
Projects
None yet
Development

No branches or pull requests

8 participants