Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caddy falls over when encountering a softlink #4672

Closed
CHTJonas opened this issue Mar 31, 2022 · 2 comments
Closed

Caddy falls over when encountering a softlink #4672

CHTJonas opened this issue Mar 31, 2022 · 2 comments
Labels
duplicate 🖇️ This issue or pull request already exists

Comments

@CHTJonas
Copy link

Caddy seems to trip up when serving a directory listing (in file browser mode) for a subdirectory when that subdirectory contains a softlink. Commands to reproduce below, but do let me know if you need anything else. Thanks for all your hard work!

$ caddy version
v2.4.6 h1:HGkGICFGvyrodcqOOclHKfvJC0qTU7vny/7FhYp9hNw=

$ uname -srvmo
Linux 5.4.0-1050-raspi #56-Ubuntu SMP PREEMPT Thu Jan 13 13:09:35 UTC 2022 aarch64 GNU/Linux
mkdir -p caddy-bug/test && cd caddy-bug
caddy file-server --listen 127.0.0.1:4523 --browse &
echo 'This is a file.' > test/file
curl -I http://127.0.0.1:4523/test/ # HTTP 200
ln test/file test/file-hardlink
curl -I http://127.0.0.1:4523/test/ # HTTP 200
ln -s test/file test/file-softlink
curl -I http://127.0.0.1:4523/test/ # HTTP 404

Bug appears to be present on Linux as well as macOS.

@francislavoie
Copy link
Member

Please try with v2.5.0-beta.1, I think that's already been fixed.

@francislavoie francislavoie added the needs info 📭 Requires more information label Mar 31, 2022
@CHTJonas
Copy link
Author

Whoops, yeah this is a dupe of #4411 - sorry. I did search issues, but forgot to delete is:open from the default filter!

@francislavoie francislavoie added duplicate 🖇️ This issue or pull request already exists and removed needs info 📭 Requires more information labels Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate 🖇️ This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants