Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qtls via quic-go breaks when building with Go 1.15 #3654

Closed
jwkohnen opened this issue Aug 14, 2020 · 1 comment · Fixed by #3642
Closed

qtls via quic-go breaks when building with Go 1.15 #3654

jwkohnen opened this issue Aug 14, 2020 · 1 comment · Fixed by #3642
Labels
duplicate 🖇️ This issue or pull request already exists upstream ⬆️ Relates to some dependency of this project

Comments

@jwkohnen
Copy link

Currently Caddy (no Caddyfile, just caddy version) terminates with a panic at startup time if built with Go 1.15. The cause is a check in quic-go that compares some TLS types from the standard library with modified (for quic) TLS types from https://github.com/marten-seemann/qtls.

Caddy can't directly do anything about this. A bunch of other software that link in quic is broken with Go 1.15. As of now quic-go/quic-go/issues/2614 seems to be the best place to track progress of this issue.

jb@ibuti:~/git/gh/caddyserver/caddy/cmd/caddy$ go version
go version go1.15 linux/amd64
jb@ibuti:~/git/gh/caddyserver/caddy/cmd/caddy$ git describe 
v2.2.0-rc.1-1-ge385be92
jb@ibuti:~/git/gh/caddyserver/caddy/cmd/caddy$ go install
jb@ibuti:~/git/gh/caddyserver/caddy/cmd/caddy$ caddy version
panic: qtls.ClientSessionState not compatible with tls.ClientSessionState

goroutine 1 [running]:
github.com/lucas-clemente/quic-go/internal/handshake.init.2()
	/home/jb/go/pkg/mod/github.com/lucas-clemente/[email protected]/internal/handshake/unsafe.go:26 +0x205```
@mohammed90
Copy link
Member

Thanks for creating the issue. It's been known since #3642.

@mohammed90 mohammed90 linked a pull request Aug 14, 2020 that will close this issue
@mholt mholt added the duplicate 🖇️ This issue or pull request already exists label Aug 14, 2020
@mholt mholt closed this as completed Aug 14, 2020
@mholt mholt added the upstream ⬆️ Relates to some dependency of this project label Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate 🖇️ This issue or pull request already exists upstream ⬆️ Relates to some dependency of this project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants