Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add events for On Demand Certificates #2344

Closed
oliverdunk opened this issue Nov 13, 2018 · 2 comments
Closed

Add events for On Demand Certificates #2344

oliverdunk opened this issue Nov 13, 2018 · 2 comments
Labels
feature ⚙️ New feature or request
Milestone

Comments

@oliverdunk
Copy link

In my blog post here, I explain how I added two new events to Caddy:

  • OnDemandCertObtainedEvent
  • OnDemandCertFailureEvent

I'm opening this issue to ask if this is something that is worth PRing to introduce upstream? It seems like a minor change, and I can't see any downsides, but I wasn't sure if there was a reason for these not existing already.

@francislavoie
Copy link
Member

francislavoie commented Nov 13, 2018

Nothing to lose by making a PR. Go for it!

Events are relatively new and it's really dependent on what kind of features plugin authors would like to implement. Your use-case definitely seems valid, so I don't see why it wouldn't get merged.

@mholt
Copy link
Member

mholt commented Aug 31, 2022

Implemented in #4984

@mholt mholt closed this as completed Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ⚙️ New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants