Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate with nix fmt #287

Open
yajo opened this issue Apr 24, 2023 · 2 comments · May be fixed by #495
Open

Integrate with nix fmt #287

yajo opened this issue Apr 24, 2023 · 2 comments · May be fixed by #495
Labels
enhancement New feature or request

Comments

@yajo
Copy link
Contributor

yajo commented Apr 24, 2023 •
edited
Loading

As you can see in the manual, there's a nix fmt option for flakes. Flakes can indicate what program should be used for formatting code. Flakes that use this project will usually be formatted using it, so I think it would be helpful to provide formatter configuration out of the box when using the flake template. Also documenting how to use it for projects that already have a flake.
@zmrocze
Copy link

zmrocze commented Apr 24, 2023 •
edited
Loading

This is much needed option, because - while the corrected formatting gets applied to staged changes - there's no way to apply formatting to all tracked files.

EDIT: its there at pre-commit run --all-files. The integration with nix fmt would be cool nevertheless.

@domenkozar
Copy link
Member

If someone makes a PR that would be great!

@domenkozar domenkozar added the enhancement New feature or request label Jul 29, 2023
shikanime added a commit to shikanime/git-hooks.nix that referenced this issue Sep 20, 2024
@shikanime
Add nix fmt hook
2dee9e8 
fixes: cachix#287
@shikanime shikanime linked a pull request Sep 20, 2024 that will close this issue
Open
shikanime added a commit to shikanime/git-hooks.nix that referenced this issue Oct 10, 2024
@shikanime
Add nix fmt hook
42fbe6a 
fixes: cachix#287
shikanime added a commit to shikanime/git-hooks.nix that referenced this issue Oct 10, 2024
@shikanime
Add nix fmt hook
fb00e51 
fixes: cachix#287
shikanime added a commit to shikanime/git-hooks.nix that referenced this issue Oct 10, 2024
@shikanime
Add nix fmt hook
d82a37a 
fixes: cachix#287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add nix fmt hook shikanime/git-hooks.nix
3 participants
@domenkozar @yajo @zmrocze