Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch names inconsistent? #26

Closed
GrahamCampbell opened this issue Dec 31, 2015 · 21 comments
Closed

Branch names inconsistent? #26

GrahamCampbell opened this issue Dec 31, 2015 · 21 comments

Comments

@GrahamCampbell
Copy link
Contributor

No description provided.

@GrahamCampbell
Copy link
Contributor Author

I think we should pull the v2.0.0-beta1 release too since we're missing all subsequent releases upto v2.0.0.

@djdefi
Copy link
Contributor

djdefi commented Dec 31, 2015

@GrahamCampbell I can remove that one - Is it looking better now?

@GrahamCampbell
Copy link
Contributor Author

2.0 should be named 2.0.0, right?

@GrahamCampbell
Copy link
Contributor Author

Also, there's no 1.2.0 branch?

@GrahamCampbell
Copy link
Contributor Author

Do we really need all these branches?

@GrahamCampbell
Copy link
Contributor Author

Would 1.2, 2.0, master not be sufficient?

@djdefi
Copy link
Contributor

djdefi commented Dec 31, 2015

I like that idea. ☝️ - Would be a lot less to maintain :)

@djdefi
Copy link
Contributor

djdefi commented Dec 31, 2015

Now we have base for the base image, master for latest upstream master, 2.0.0 for tagging 2.x.x releases, and 1.2.1 for 1.2.1

@GrahamCampbell
Copy link
Contributor Author

The branches should be called 1.2 and 2.0.

@GrahamCampbell
Copy link
Contributor Author

2.0.0 can't be right, because it should have the 2.0.4 code on it?

@GrahamCampbell
Copy link
Contributor Author

Meh, do we even need branches?

@GrahamCampbell
Copy link
Contributor Author

What's wrong with just generating tags from the master branch?

@GrahamCampbell
Copy link
Contributor Author

Meh, it's just very odd to have 2.0 as a branch, but it doesn't actually contain the 2.0.3 commit in it?

@GrahamCampbell
Copy link
Contributor Author

Don't make anymore changes, lol.

@djdefi
Copy link
Contributor

djdefi commented Dec 31, 2015

Fixed and fixed, 2.0.4 code is in 2.0 branch now.

The reason for the branches is:

Master: Pulls upstream master from cachet/cachet (Could be used by a developer potentially to work on upstream)
2.0: pulls 2.0.x releases (mainly to just tag them, if we had done this earlier the 2.0.3 commit would be there also...)

@GrahamCampbell
Copy link
Contributor Author

2.0: pulls 2.0.x releases (mainly to just tag them, if we had done this earlier the 2.0.3 commit would be there also...)

Sure. Can we follow that method in future please?

@GrahamCampbell
Copy link
Contributor Author

Also, the master needs rebasing against 2.0 doesn't it?

@GrahamCampbell
Copy link
Contributor Author

There are no more planned 1.x or 2.0.x releases btw. The next release will be in the 2.1.x series.

@djdefi
Copy link
Contributor

djdefi commented Dec 31, 2015

Definitely will follow this in future, will try to write up a CONTRIBUTING.md related to this flow.

Master shouldn't really need a rebase as there hasn't been any changes to the Dockerfile itself, other than changing the release # that it being downloaded. I will double check it though.

@GrahamCampbell
Copy link
Contributor Author

The rebase was mainly for OCD to have it so it's directly applied ontop of 2.0.

@djdefi
Copy link
Contributor

djdefi commented Dec 31, 2015

👍 will see if can fix that up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants