Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for keypos #44

Closed
edescourtis opened this issue Aug 16, 2019 · 7 comments
Closed

Missing support for keypos #44

edescourtis opened this issue Aug 16, 2019 · 7 comments

Comments

@edescourtis
Copy link

edescourtis commented Aug 16, 2019

For people using records in ets tables, it is essential to support setting the keypos.

@cabol
Copy link
Owner

cabol commented Aug 16, 2019

@edescourtis could you please elaborate more on that, why do you say it is not supported? In what case keypos doesn't work or it is not supported by shards, and it is supported normally by ets? I need more details, please.

@edescourtis
Copy link
Author

When using records (tagged tuples) it is always the case that the key (used for lookups for example) is not stored at position 1 (typically the key would be at position 2). keypos is something mandatory to support records in ets.

It is of course supported by ets and doesn't work with shards otherwise I wouldn't have filed an issue.

You are also missing select_replace see my branch in case you want to cherry-pick it.

@cabol
Copy link
Owner

cabol commented Aug 20, 2019

Ok, I'll check it out, thanks!

@cabol
Copy link
Owner

cabol commented Aug 20, 2019

I found the issue with keypos, I'll try to fix it as soon as I can, thanks again!

@edescourtis
Copy link
Author

No thank you for making this library! I will definitely use it in the future.

cabol added a commit that referenced this issue Aug 20, 2019
@cabol
Copy link
Owner

cabol commented Aug 20, 2019

Fixed on the master branch! Please try it out and let me know how it goes and if we can close the issue. For select_replace I will create another one.

@cabol
Copy link
Owner

cabol commented Aug 23, 2019

I will close the issue, feel free to open it in case it doesn't work or you find something wrong with it.

@cabol cabol closed this as completed Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants