Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTP < 18 not supported #13

Closed
lrascao opened this issue Jun 5, 2016 · 2 comments
Closed

OTP < 18 not supported #13

lrascao opened this issue Jun 5, 2016 · 2 comments

Comments

@lrascao
Copy link

lrascao commented Jun 5, 2016

shards_owner_sup is making use of the newly introduced map support for supervisor child specs and flags (https://www.erlang.org/downloads/18.0), this prevents older versions from being able to use shards. Maybe co-existence could be possible by detecting the target OTP version and generating either the old tuple format or the new one.
cabol added a commit that referenced this issue Jun 6, 2016
@cabol
[#13] OTP < 18 not supported. Allow backwards compatibility from OTP …
f6e8d34 
…17 onwards.
@cabol cabol mentioned this issue Jun 6, 2016
Merged
cabol added a commit that referenced this issue Jun 6, 2016
@cabol
Merge pull request #14 from cabol/v0.1.1
01f1697 
Enhancements and fix issue #13.
@cabol
Copy link
Owner

cabol commented Jun 6, 2016

@lrascao I think is fixed. Check out the master branch and let me know if we can close this issue. Thanks again :)!!

@lrascao
Copy link
Author

lrascao commented Jun 6, 2016 •
edited
Loading

works great! do you think you can release a new tag?
thanks!

@lrascao lrascao closed this as completed Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lrascao @cabol