Languages feature #12
Conversation
|
Nice work, there is more change than I anticipated tho |
| { | ||
| "af": { | ||
| "and": [ | ||
| "* ", |
There was a problem hiding this comment.
I also noticed this in gherkin documentation: https://cucumber.io/docs/gherkin/reference/#gherkin-dialects
what is meant by *. Is it like a wild card, catch-all?
in that case Given, When, Then, And, But all are equal. And contextually there is no difference (this note probably is more related to cabbage library on how to handle step definitions and how important it is to use correct step type. It seems that there is 0 importance to it, only easier to read for the eye because is more similar to plain English)
There was a problem hiding this comment.
I'm really not a gherkin expert, but yes it seems like it can be used to avoid redundancy in feature files (cf https://stackoverflow.com/a/27363033). I removed it from the keywords list in Keywords.cleanup_list/1 but maybe it's better to leave it there, what do you think ?
There was a problem hiding this comment.
I think that the primary concern for this library should be compatibility with original spec. So if gherkin/cucumber supports it, we should as well. So * should be supported.
|
What we should do I think, is to create some base performance test suite. Which we can run, on the current implementation and yours and use it as a reference in future, to see how code changes impacts library performance |
|
Hey @revati, yes some performance tests might be nice but I really don't know where to start with it... if you have some guidelines I'll be glad to help on this ! |
|
Yes, I joined the cucumber slack channel and they pointed out that there is https://github.com/cucumber/cucumber/tree/master/gherkin/testdata which can be used as
I will set up a seperate branch where will be benchee base, so you will just need to merge it in and run command |
Hi there,
As I noticed in #11, I couldn't find how to use gherkin with some other languages than english. I'm just starting my Elixir journey so this PR is surely not perfect, at least the tests are passing and it seems to work well (I tested it only in french and spanish).
I've just created a Keywords module which holds a struct and some functions to interact with keywords loaded from a gherkin-languages.json file at the root of the project (a script to automatically download this file from the official gherkin repo everytime this project gets published could be a good thing to add). Then I updated the parsers to handle those keywords instead of just plain strings in english.
Anyway, let me know what you think about it !