chore: catch emptycfg slice and non-string targets

Signed-off-by: Bruno Bressi <[email protected]>

pkg/sparrow/run.go

@@ -151,6 +151,7 @@ func (s *Sparrow) updateCheckTargets(cfg any) any {
 		return nil
 	}
 
+	// check if map with targets
 	checkCfg, ok := cfg.(map[string]any)
 	if !ok {
 		return checkCfg
@@ -159,13 +160,21 @@ func (s *Sparrow) updateCheckTargets(cfg any) any {
 		return checkCfg
 	}
 
+	// Check if targets is a slice
 	actuali, ok := checkCfg["targets"].([]any)
 	if !ok {
 		return checkCfg
 	}
+	if len(actuali) == 0 {
+		return checkCfg
+	}
 
+	// convert to string slice
 	var actual []string
 	for _, v := range actuali {
+		if _, ok := v.(string); !ok {
+			return checkCfg
+		}
 		actual = append(actual, v.(string))
 	}
 	var urls []string

pkg/sparrow/run_test.go

@@ -266,6 +266,36 @@ func TestSparrow_updateCheckTargets(t *testing.T) {
 				"targets": "not a slice",
 			},
 		},
+		{
+			name: "config with empty targets",
+			config: map[string]any{
+				"targets": []any{},
+			},
+			globalTargets: gt,
+			expected: map[string]any{
+				"targets": []any{},
+			},
+		},
+		{
+			name: "config with non string target slice",
+			config: map[string]any{
+				"targets": []any{1, 2, 3},
+			},
+			globalTargets: gt,
+			expected: map[string]any{
+				"targets": []any{1, 2, 3},
+			},
+		},
+		{
+			name: "config with mixed target slice",
+			config: map[string]any{
+				"targets": []any{"https://gitlab.com", 1, 3},
+			},
+			globalTargets: gt,
+			expected: map[string]any{
+				"targets": []any{"https://gitlab.com", 1, 3},
+			},
+		},
 		{
 			name: "config with targets",
 			config: map[string]any{