Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: failed to parse timezone #61

Closed
weixcloud opened this issue Sep 30, 2024 · 3 comments · Fixed by #62
Closed

Bug: failed to parse timezone #61

weixcloud opened this issue Sep 30, 2024 · 3 comments · Fixed by #62
Assignees
Labels
bug Something isn't working

Comments

@weixcloud
Copy link

weixcloud commented Sep 30, 2024

Issue

I deployed the operator in my local cluster for testing, When I use the timespan with any time zone like Australia/Sydney, the operator printed the following error:

annotation: failed to parse relative timespan: failed to parse timezone: 
unknown time zone Australia/Sydney" workload=demo-deploy
 namespace=xxx

Problem to solve

Further details

Proposal

There are two options to solve it:

  • add _ "time/tzdata" in the main.go
  • Or change the docker image by adding the following line:
FROM scratch
COPY --from=builder /usr/local/go/lib/time/zoneinfo.zip /zoneinfo.zip
ENV ZONEINFO=/zoneinfo.zip

Who can address the issue

Other links/references

@weixcloud
Copy link
Author

@jonathan-mayer Could you please have a look at it? It should be easy to fix with the option 1. Thanks

@jonathan-mayer jonathan-mayer added the bug Something isn't working label Oct 1, 2024
@jonathan-mayer jonathan-mayer self-assigned this Oct 1, 2024
@jonathan-mayer
Copy link
Member

Hey @weixcloud, sorry for the delayed response, I am currently on vacation. Thanks for finding this issue. I will have a look at this and release a new version of the downscaler once its fixed.

@jonathan-mayer
Copy link
Member

I've implemented a fix in #62 it should be merged tomorrow after being reviewed and a new version should automatically be released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants