Update mysql 8 connection string for localdb tests #4710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
inodb
reviewed
Aug 25, 2023
| db.driver=com.mysql.jdbc.Driver | ||
| db.connection_string=jdbc:mysql://cbioportal-database-container/ | ||
| db.connection_string=jdbc:mysql://cbioportal-database:3306/cbioportal?useSSL=false&allowPublicKeyRetrieval=true |
There was a problem hiding this comment.
Why does this have a different name from:
https://github.com/cBioPortal/cbioportal-docker-compose/blob/master/docker-compose.yml#L24
There was a problem hiding this comment.
@inodb In my understanding, using a custom container name and service name is the same, in this case, we are using the service name, I just wanted to keep in sync with other places we have:
https://github.com/cBioPortal/cbioportal-docker-compose/pull/22/files
https://github.com/cBioPortal/cbioportal/pull/10037/files#diff-65ae1168eecd2c82b28b52c8a2c70866716e326bfa781144b33f0d74909103d9R49
pvannierop
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR will update the local e2e test with the latest DB connection string and delete outdated ones.