Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd): add flag to suppress header/footer #95

Merged
merged 1 commit into from
Apr 25, 2018

Conversation

raghur
Copy link
Contributor

@raghur raghur commented Apr 24, 2018

see #83 is this what this issue refers to?

see bytesparadise#83 is this what this issue refers to?
@codecov
Copy link

codecov bot commented Apr 24, 2018

Codecov Report

Merging #95 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   81.71%   81.73%   +0.01%     
==========================================
  Files          35       35              
  Lines        2100     2102       +2     
==========================================
+ Hits         1716     1718       +2     
  Misses        258      258              
  Partials      126      126

@xcoulon xcoulon merged commit 4a31775 into bytesparadise:master Apr 25, 2018
@xcoulon
Copy link
Member

xcoulon commented Apr 25, 2018

thanks for this PR, @raghur!

@xcoulon
Copy link
Member

xcoulon commented Apr 25, 2018

@raghur looking at asciidoc and asciidoctor, I think that we should align with them in term of commands, so the switch from one tool to another would be more straightforward. I've opened a new issue about it, in order to take the source file to convert without the need for a specific flag, and replace the -n with -s. Feel free to take a look at it if you want ;) (since you've already worked on the cmd pkg)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants