feature(parser): custom subs on paragraphs #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #726 +/- ##
==========================================
- Coverage 84.93% 84.91% -0.02%
==========================================
Files 76 76
Lines 5224 5311 +87
==========================================
+ Hits 4437 4510 +73
- Misses 496 505 +9
- Partials 291 296 +5 |
|
marking this PR as "draft" since there are still some substitutions to implements and tests to add in the |
xcoulon
force-pushed
the
Issue597_custom_subs_paragraphs
branch
5 times, most recently
from
dd5d31b to
884c13a
Compare
gdamore
reviewed
Aug 1, 2020
make/go.mk
Outdated
| @@ -42,12 +42,12 @@ generate: install-pigeon | |||
| generate-optimized: install-pigeon | |||
| @echo "generating the parser (optimized)..." | |||
| @pigeon -optimize-parser \ | |||
| -alternate-entrypoints AsciidocRawDocument,RawFile,TextDocument,DocumentRawBlock,FileLocation,IncludedFileLine,InlineLinks,LabeledListItemTerm,NormalBlockContent,NormalParagraphContent,VerseBlockContent,MarkdownQuoteBlockAttribution,InlineElements \ | |||
| -alternate-entrypoints AsciidocRawDocument,RawFile,TextDocument,DocumentRawBlock,FileLocation,IncludedFileLine,InlineLinks,LabeledListItemTerm,NormalParagraphContentSubstitution,NormalBlockContentSubstitution,VerseBlockContentSubstitution,MarkdownQuoteBlockAttribution,InlineElements,QuotedTextSubstitution,NoneSubstitution,AttributesSubstitution,ReplacementsSubstitution \ | |||
There was a problem hiding this comment.
My PR that moves this to go generate will need to be updated if this merges first. Or vice versa.
There was a problem hiding this comment.
yes, I've taken this change into account in my latest commit (I pushed with --force)
xcoulon
force-pushed
the
Issue597_custom_subs_paragraphs
branch
from
884c13a to
fd51649
Compare
Support for one or more custom substitutions Starting with Rawline elements which are parsed and result in other elements. Subsequent substitutions only apply on the StringElements. At the end of the substitutions, the lines are preserved Also, fix issues with single line comments which should not start with spaces before the `//` marker Fixes bytesparadise#597 Signed-off-by: Xavier Coulon <[email protected]>
xcoulon
force-pushed
the
Issue597_custom_subs_paragraphs
branch
from
fd51649 to
9c77a19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for one or more custom substitutions
Starting with Rawline elements which are parsed
and result in other elements. Subsequent substitutions
only apply on the StringElements.
At the end of the substitutions, the lines are preserved
Also, fix issues with single line comments which should not
start with spaces before the
//markerFixes #597
Signed-off-by: Xavier Coulon [email protected]