Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commit message linter #700

Open
moorereason opened this issue Jul 6, 2020 · 5 comments
Open

Add commit message linter #700

moorereason opened this issue Jul 6, 2020 · 5 comments

Comments

@moorereason
Copy link
Contributor

Enforce Angular Commit Message Guidelines within GitHub.

@xcoulon
Copy link
Member

xcoulon commented Jul 6, 2020

I need to see if such a linter already exist (as a GitHub Action would be ideal)

@moorereason
Copy link
Contributor Author

The most popular GH Action appears to be https://github.com/wagoid/commitlint-github-action.

There's a simple GH App here: https://github.com/zeke/semantic-pull-requests.

@xcoulon
Copy link
Member

xcoulon commented Jul 6, 2020

cool, thanks for the links @moorereason! I'll give it a try soon

@gdamore
Copy link
Collaborator

gdamore commented Jul 6, 2020

Is there some meaningful tooling that consumes these commit messages? TBH I really find them to be kind of a pain -- I've not seen them used anywhere else before.

@xcoulon
Copy link
Member

xcoulon commented Jul 6, 2020

yes, I generate the changelog that appears on https://github.com/bytesparadise/libasciidoc/releases using https://github.com/conventional-changelog/conventional-changelog and it parses the commit message to determine the type commit it was, and the scope.

@xcoulon xcoulon added this to the v0.5.0 milestone Jul 7, 2020
@xcoulon xcoulon modified the milestones: v0.5.0, backlog Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants