feature(renderer): Top level table styling #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also renamed some attributes (the Go types, not the string values) to make better reuse of them for tables. |
This provides top-level support for attributes to style the entire table (frame, grid, float, stripes, width, autowidth). The cols attribute is still not handled, meaning that it is still not possible to configure column widths.
|
(Whoops, forgot to regenerate the parser... -- it was impacted by the rename AttrImageWidth to AttrWidth) |
Codecov Report
@@ Coverage Diff @@
## master #690 +/- ##
==========================================
+ Coverage 85.24% 85.31% +0.07%
==========================================
Files 71 71
Lines 4790 4816 +26
==========================================
+ Hits 4083 4109 +26
Misses 451 451
Partials 256 256 |
xcoulon
approved these changes
Jul 5, 2020
xcoulon
reviewed
Jul 5, 2020
| @@ -99,6 +93,16 @@ const ( | |||
| AttrCaption = "caption" | |||
| // AttrStyle block or list style | |||
| AttrStyle = "style" | |||
| // AttrWidth the `width` attribute used ior images, tables, and so forth | |||
| AttrWidth = "width" | |||
There was a problem hiding this comment.
Maybe we should also rename AttrImageHeight to AttrHeight for the sake of consistency?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides top-level support for attributes to style the
entire table (frame, grid, float, stripes, width, autowidth).
The cols attribute is still not handled, meaning that it is
still not possible to configure column widths.