bug(parser): Inline attribute parsing is incorrect #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Note that block attributes, and some other inline attributes, suffer from this problem -- this PR only fixes icon and image inline attributes.) While working on some new support for align and float attributes, we noticed that the parser was fragile, and failed on certain cases including double embedded whitespace, embedded quote marks, and others. This logic will be expanded to other elements and to block attributes; this incremental PR should be easier to review.
Codecov Report
@@ Coverage Diff @@
## master #684 +/- ##
==========================================
- Coverage 85.23% 85.18% -0.06%
==========================================
Files 71 71
Lines 4720 4744 +24
==========================================
+ Hits 4023 4041 +18
- Misses 444 449 +5
- Partials 253 254 +1 |
xcoulon
approved these changes
Jul 3, 2020
|
thanks @gdamore! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note that block attributes, and some other inline attributes,
suffer from this problem -- this PR only fixes icon and image
inline attributes.)
While working on some new support for align and float attributes,
we noticed that the parser was fragile, and failed on certain
cases including double embedded whitespace, embedded quote marks,
and others.
This logic will be expanded to other elements and to block
attributes; this incremental PR should be easier to review.