fix(parser): quoted text newline handling #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quoted texts (such as bold) should span newlines, but should not be permitted to span paragraphs or blocks. This fixes all of them, and includes parser and renderer validation. Fixes bytesparadise#623
Codecov Report
@@ Coverage Diff @@
## master #624 +/- ##
=======================================
Coverage 86.78% 86.78%
=======================================
Files 70 70
Lines 4395 4395
=======================================
Hits 3814 3814
Misses 369 369
Partials 212 212 |
|
I did not copy and modify the rendering tests for HTML to XHTML in this case. I don't think they add any useful extra value in the XHTML tree, since the parse tree is already validated, and these formats are not different between HTML and XHTML. |
xcoulon
approved these changes
Jun 20, 2020
| types.QuotedText{ | ||
| Kind: types.Bold, | ||
| Elements: []interface{}{ | ||
| types.StringElement{Content: "some bold\ncontent"}, |
There was a problem hiding this comment.
now I realize that the line may actually span on multiple lines, but it's not a big deal I guess...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoted texts (such as bold) should span newlines, but should
not be permitted to span paragraphs or blocks. This fixes
all of them, and includes parser and renderer validation.
Fixes #623