feat(renderer) Add xhtml5 support #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for XHTML5 output, tests, and the -b flag (which can now be used like -b [html,html5,xhtml,xhtml5]. (Also --backend.) Tests are enclosed, and we leverage as much as we can from the HTML5 backend.
gdamore
commented
Jun 16, 2020
|
|
||
| var templates = html5.Templates() | ||
|
|
||
| //sgml.Templates{ |
There was a problem hiding this comment.
Ah I meant to delete this comment. Will follow up.
Codecov Report
@@ Coverage Diff @@
## master #618 +/- ##
==========================================
- Coverage 86.78% 86.76% -0.03%
==========================================
Files 69 70 +1
Lines 4322 4374 +52
==========================================
+ Hits 3751 3795 +44
- Misses 363 368 +5
- Partials 208 211 +3 |
xcoulon
reviewed
Jun 16, 2020
|
|
||
| var templates = html5.Templates() | ||
|
|
||
| //sgml.Templates{ |
There was a problem hiding this comment.
could you remove this commented out lines?
Also, added test cases to cover both html and xhtml5 backends, as well as invalid backends.
|
thanks for this contribution @gdamore 🙌 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for XHTML5 output, tests, and the -b
flag (which can now be used like -b [html,html5,xhtml,xhtml5].
(Also --backend.) Tests are enclosed, and we leverage as much
as we can from the HTML5 backend.