feat(renderer): role not honored on h1 titles (#583) #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The way I scraped the role off the attributes of the header felt a little slimy, but it seems the best way to match asciidoctor. |
|
NB: I fixed the style (apparently some whitespace crept in) -- please squash (or I can do that for you) before merging. |
Codecov Report
@@ Coverage Diff @@
## master #584 +/- ##
==========================================
+ Coverage 88.40% 88.41% +0.01%
==========================================
Files 66 66
Lines 4536 4542 +6
==========================================
+ Hits 4010 4016 +6
Misses 342 342
Partials 184 184 |
This adds support for setting the role on a level 0 title, which will cause the class for the document body to be set.
|
I squashed, because there was an unintended change (something I reverted) in the parser. |
xcoulon
approved these changes
Jun 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for setting the role on a level 0 title,
which will cause the class for the document body to be set.