Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): expose authors and revision in the document attributes #521

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented Mar 29, 2020

also, expand the attributes so we can substitute the 'author',
'firstname', etc. attributes in the document during the processing

fixes #517

Signed-off-by: Xavier Coulon [email protected]

also, expand the attributes so we can substitute the 'author',
'firstname', etc. attributes in the document during the processing

fixes bytesparadise#517

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon force-pushed the Issue517_document_attribute_substitutions branch from 41847ac to 1d37724 Compare March 29, 2020 13:40
@codecov
Copy link

codecov bot commented Mar 29, 2020

Codecov Report

Merging #521 into master will decrease coverage by 0.29%.
The diff coverage is 99.05%.

@@            Coverage Diff             @@
##           master     #521      +/-   ##
==========================================
- Coverage   86.26%   85.97%   -0.30%     
==========================================
  Files          67       65       -2     
  Lines        4733     4763      +30     
==========================================
+ Hits         4083     4095      +12     
- Misses        480      498      +18     
  Partials      170      170              

@xcoulon xcoulon merged commit 9335817 into bytesparadise:master Mar 29, 2020
@xcoulon xcoulon deleted the Issue517_document_attribute_substitutions branch March 29, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Author and revision not accessible in document
1 participant