Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser): include document attribute when processing section 0 #451

Merged

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented Dec 22, 2019

get the "document attributes" by reading the beginning of the
first blocks of the draft document, and use them while processing
the section 0 title.

Fixes #447

Signed-off-by: Xavier Coulon [email protected]

get the "document attributes" by reading the beginning of the
first blocks of the draft document, and use them while processing
the section 0 title.

Fixes bytesparadise#447

Signed-off-by: Xavier Coulon <[email protected]>
@codecov
Copy link

codecov bot commented Dec 22, 2019

Codecov Report

Merging #451 into master will decrease coverage by <.01%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
- Coverage   87.44%   87.43%   -0.01%     
==========================================
  Files          60       60              
  Lines        4087     4108      +21     
==========================================
+ Hits         3574     3592      +18     
- Misses        344      346       +2     
- Partials      169      170       +1

@xcoulon xcoulon merged commit 0826b73 into bytesparadise:master Dec 22, 2019
@xcoulon xcoulon deleted the Issue447_include_doc_attr_after_section0 branch December 22, 2019 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include document attribute declaration after section 0 in document attributes
1 participant