feat(parser): support document attributes in links #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support the whole link as a document attribute (or vice versa?). to do so: - apply the document attribute substitutions during the document processing - then reparse the paragraph line (if needed) to look for inline links Fixes bytesparadise#351 Signed-off-by: Xavier Coulon <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
==========================================
- Coverage 87.38% 87.29% -0.09%
==========================================
Files 59 59
Lines 4003 4054 +51
==========================================
+ Hits 3498 3539 +41
- Misses 340 348 +8
- Partials 165 167 +2 |
Signed-off-by: Xavier Coulon <[email protected]>
Signed-off-by: Xavier Coulon <[email protected]>
Signed-off-by: Xavier Coulon <[email protected]>
Signed-off-by: Xavier Coulon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support the whole link as a document attribute (or vice versa?).
to do so:
processing
Fixes #351
Signed-off-by: Xavier Coulon [email protected]