Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(renderer): do not include section 0 element #432

Merged

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented Oct 27, 2019

unless there's a relevant element before. Otherwise,
just retain the section elements

fixes #425

Signed-off-by: Xavier Coulon [email protected]

unless there's a relevant element before. Otherwise,
just retain the section elements

fixes bytesparadise#425

Signed-off-by: Xavier Coulon <[email protected]>
@codecov
Copy link

codecov bot commented Oct 27, 2019

Codecov Report

Merging #432 into master will decrease coverage by <.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #432      +/-   ##
==========================================
- Coverage   87.38%   87.38%   -0.01%     
==========================================
  Files          59       59              
  Lines        3957     3980      +23     
==========================================
+ Hits         3458     3478      +20     
- Misses        336      338       +2     
- Partials      163      164       +1

@xcoulon xcoulon merged commit bfff288 into bytesparadise:master Oct 27, 2019
@xcoulon xcoulon deleted the Issue425_invalid_include_section0 branch October 27, 2019 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid file inclusion with section level 0
1 participant