Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser/renderer): use main file path to start inclusions #429

Merged
merged 1 commit into from
Oct 26, 2019

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented Oct 26, 2019

use the base dir of the top/root parent as the starting dir
when processing file inclusions

modify matchers to support optional filename

fixes #424

Signed-off-by: Xavier Coulon [email protected]

use the base dir of the top/root parent as the starting dir
when processing file inclusions

modify matchers to support optional filename

fixes bytesparadise#424

Signed-off-by: Xavier Coulon <[email protected]>
@codecov
Copy link

codecov bot commented Oct 26, 2019

Codecov Report

Merging #429 into master will decrease coverage by 0.1%.
The diff coverage is 86.25%.

@@            Coverage Diff             @@
##           master     #429      +/-   ##
==========================================
- Coverage   87.43%   87.33%   -0.11%     
==========================================
  Files          58       59       +1     
  Lines        3940     3986      +46     
==========================================
+ Hits         3445     3481      +36     
- Misses        331      339       +8     
- Partials      164      166       +2

@xcoulon xcoulon merged commit 5bc6ab4 into bytesparadise:master Oct 26, 2019
@xcoulon xcoulon deleted the Issue424_include_path branch October 26, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid path to file to include
1 participant