fix(parser): support encoded spaces in link URL #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xcoulon
changed the title
looks like the `%` character was missing in the previous fix for link URLs :/ also, prevent spaces in user-defined macro values. Fixes bytesparadise#419 Signed-off-by: Xavier Coulon <[email protected]>
xcoulon
force-pushed
the
Issue419_link_encoded_spaces
branch
from
b1046b8 to
246800c
Compare
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
==========================================
+ Coverage 84.86% 87.05% +2.19%
==========================================
Files 57 57
Lines 4507 3910 -597
==========================================
- Hits 3825 3404 -421
+ Misses 518 341 -177
- Partials 164 165 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looks like the
%character was missing in the previousfix for link URLs :/
also, prevent spaces in user-defined macro values.
Fixes #419
Signed-off-by: Xavier Coulon [email protected]