Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser): report an error when tag to limit file inclusion could not be found #407

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented Sep 12, 2019

compares the tags that were actually processed during the file inclusion
with the tags provided in the macro

also, move the file inclusion funcs in a separate file

fixes #393

Signed-off-by: Xavier Coulon [email protected]

…not be found

compares the tags that were actually processed during the file inclusion
with the tags provided in the macro

also, move the file inclusion funcs in a separate file

fixes bytesparadise#393

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon merged commit fc187b4 into bytesparadise:master Sep 12, 2019
@xcoulon xcoulon deleted the Issue393_report_error_unknown_include_tag branch September 12, 2019 20:06
@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #407 into master will increase coverage by 0.03%.
The diff coverage is 58.6%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   84.89%   84.93%   +0.03%     
==========================================
  Files          48       49       +1     
  Lines        4184     4195      +11     
==========================================
+ Hits         3552     3563      +11     
  Misses        482      482              
  Partials      150      150

18 similar comments
@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #407 into master will increase coverage by 0.03%.
The diff coverage is 58.6%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   84.89%   84.93%   +0.03%     
==========================================
  Files          48       49       +1     
  Lines        4184     4195      +11     
==========================================
+ Hits         3552     3563      +11     
  Misses        482      482              
  Partials      150      150

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #407 into master will increase coverage by 0.03%.
The diff coverage is 58.6%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   84.89%   84.93%   +0.03%     
==========================================
  Files          48       49       +1     
  Lines        4184     4195      +11     
==========================================
+ Hits         3552     3563      +11     
  Misses        482      482              
  Partials      150      150

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #407 into master will increase coverage by 0.03%.
The diff coverage is 58.6%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   84.89%   84.93%   +0.03%     
==========================================
  Files          48       49       +1     
  Lines        4184     4195      +11     
==========================================
+ Hits         3552     3563      +11     
  Misses        482      482              
  Partials      150      150

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #407 into master will increase coverage by 0.03%.
The diff coverage is 58.6%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   84.89%   84.93%   +0.03%     
==========================================
  Files          48       49       +1     
  Lines        4184     4195      +11     
==========================================
+ Hits         3552     3563      +11     
  Misses        482      482              
  Partials      150      150

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #407 into master will increase coverage by 0.03%.
The diff coverage is 58.6%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   84.89%   84.93%   +0.03%     
==========================================
  Files          48       49       +1     
  Lines        4184     4195      +11     
==========================================
+ Hits         3552     3563      +11     
  Misses        482      482              
  Partials      150      150

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #407 into master will increase coverage by 0.03%.
The diff coverage is 58.6%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   84.89%   84.93%   +0.03%     
==========================================
  Files          48       49       +1     
  Lines        4184     4195      +11     
==========================================
+ Hits         3552     3563      +11     
  Misses        482      482              
  Partials      150      150

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #407 into master will increase coverage by 0.03%.
The diff coverage is 58.6%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   84.89%   84.93%   +0.03%     
==========================================
  Files          48       49       +1     
  Lines        4184     4195      +11     
==========================================
+ Hits         3552     3563      +11     
  Misses        482      482              
  Partials      150      150

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #407 into master will increase coverage by 0.03%.
The diff coverage is 58.6%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   84.89%   84.93%   +0.03%     
==========================================
  Files          48       49       +1     
  Lines        4184     4195      +11     
==========================================
+ Hits         3552     3563      +11     
  Misses        482      482              
  Partials      150      150

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #407 into master will increase coverage by 0.03%.
The diff coverage is 58.6%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   84.89%   84.93%   +0.03%     
==========================================
  Files          48       49       +1     
  Lines        4184     4195      +11     
==========================================
+ Hits         3552     3563      +11     
  Misses        482      482              
  Partials      150      150

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #407 into master will increase coverage by 0.03%.
The diff coverage is 58.6%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   84.89%   84.93%   +0.03%     
==========================================
  Files          48       49       +1     
  Lines        4184     4195      +11     
==========================================
+ Hits         3552     3563      +11     
  Misses        482      482              
  Partials      150      150

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #407 into master will increase coverage by 0.03%.
The diff coverage is 58.6%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   84.89%   84.93%   +0.03%     
==========================================
  Files          48       49       +1     
  Lines        4184     4195      +11     
==========================================
+ Hits         3552     3563      +11     
  Misses        482      482              
  Partials      150      150

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #407 into master will increase coverage by 0.03%.
The diff coverage is 58.6%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   84.89%   84.93%   +0.03%     
==========================================
  Files          48       49       +1     
  Lines        4184     4195      +11     
==========================================
+ Hits         3552     3563      +11     
  Misses        482      482              
  Partials      150      150

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #407 into master will increase coverage by 0.03%.
The diff coverage is 58.6%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   84.89%   84.93%   +0.03%     
==========================================
  Files          48       49       +1     
  Lines        4184     4195      +11     
==========================================
+ Hits         3552     3563      +11     
  Misses        482      482              
  Partials      150      150

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #407 into master will increase coverage by 0.03%.
The diff coverage is 58.6%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   84.89%   84.93%   +0.03%     
==========================================
  Files          48       49       +1     
  Lines        4184     4195      +11     
==========================================
+ Hits         3552     3563      +11     
  Misses        482      482              
  Partials      150      150

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #407 into master will increase coverage by 0.03%.
The diff coverage is 58.6%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   84.89%   84.93%   +0.03%     
==========================================
  Files          48       49       +1     
  Lines        4184     4195      +11     
==========================================
+ Hits         3552     3563      +11     
  Misses        482      482              
  Partials      150      150

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #407 into master will increase coverage by 0.03%.
The diff coverage is 58.6%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   84.89%   84.93%   +0.03%     
==========================================
  Files          48       49       +1     
  Lines        4184     4195      +11     
==========================================
+ Hits         3552     3563      +11     
  Misses        482      482              
  Partials      150      150

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #407 into master will increase coverage by 0.03%.
The diff coverage is 58.6%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   84.89%   84.93%   +0.03%     
==========================================
  Files          48       49       +1     
  Lines        4184     4195      +11     
==========================================
+ Hits         3552     3563      +11     
  Misses        482      482              
  Partials      150      150

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #407 into master will increase coverage by 0.03%.
The diff coverage is 58.6%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   84.89%   84.93%   +0.03%     
==========================================
  Files          48       49       +1     
  Lines        4184     4195      +11     
==========================================
+ Hits         3552     3563      +11     
  Misses        482      482              
  Partials      150      150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

report an error when tag to limit file inclusion could not be found
1 participant