Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser): support double punctuation in quoted text #39

Merged

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented Oct 28, 2017

Signed-off-by: Xavier Coulon [email protected]

@codecov
Copy link

codecov bot commented Oct 28, 2017

Codecov Report

Merging #39 into master will decrease coverage by 0.46%.
The diff coverage is 20%.

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   73.96%   73.49%   -0.47%     
==========================================
  Files          20       20              
  Lines        1540     1543       +3     
==========================================
- Hits         1139     1134       -5     
- Misses        315      321       +6     
- Partials       86       88       +2

add a `LIMITATIONS.adoc` file to report limitations or
differences with Asciidoc/Asciidoctor when using nested
quotes or unbalanced quotes.

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon force-pushed the quoted_text_with_double_punctuation branch from e00b7e1 to e949d34 Compare October 31, 2017 22:09
@xcoulon xcoulon merged commit f7f82e9 into bytesparadise:master Oct 31, 2017
xcoulon added a commit to xcoulon/libasciidoc that referenced this pull request Feb 24, 2019
With a minor change in the Asciidoctor output:
libasciidoc renders single quotes with the `&bytesparadise#39;` HTML entity,
which produce the same result in the browser.

Fixes bytesparadise#303

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit that referenced this pull request Feb 24, 2019
With a minor change in the Asciidoctor output:
libasciidoc renders single quotes with the `&#39;` HTML entity,
which produce the same result in the browser.

Fixes #303

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon deleted the quoted_text_with_double_punctuation branch February 25, 2019 08:24
xcoulon added a commit to xcoulon/libasciidoc that referenced this pull request May 23, 2020
No need to replace ' and " with &bytesparadise#39; and &bytesparadise#34;

Fixes bytesparadise#565

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit that referenced this pull request May 23, 2020
No need to replace ' and " with &#39; and &#34;

Fixes #565

Signed-off-by: Xavier Coulon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant