Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(renderer): fix panic in ToC when doc has no section #285

Merged
merged 2 commits into from
Feb 8, 2019

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented Feb 6, 2019

fixes #284

@xcoulon
Copy link
Member Author

xcoulon commented Feb 6, 2019

Waiting to see if build failures on Travis-ci with the windows machines can be fixed. Problem reported on the community forum at https://travis-ci.community/t/syntax-error-during-job-setup-using-golang/2164

@moorereason
Copy link
Contributor

Looks like Travis CI is fixed now. Try restarting the Windows jobs for this PR.

@xcoulon
Copy link
Member Author

xcoulon commented Feb 8, 2019

@moorereason yes, indeed, I just saw that ;)

@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #285 into master will increase coverage by 0.01%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
+ Coverage   85.36%   85.38%   +0.01%     
==========================================
  Files          38       38              
  Lines        3718     3721       +3     
==========================================
+ Hits         3174     3177       +3     
  Misses        406      406              
  Partials      138      138

@xcoulon xcoulon merged commit f7ee178 into bytesparadise:master Feb 8, 2019
@xcoulon xcoulon deleted the Issue284_toc_panic branch February 8, 2019 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when TOC rendering.
2 participants