Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): add windows and osx builds to Travis #224

Merged
merged 1 commit into from
Oct 26, 2018

Conversation

moorereason
Copy link
Contributor

@moorereason moorereason commented Oct 24, 2018

Fixes #223
Fixes #224

@moorereason moorereason changed the title feat(build): add windows builds to Travis WIP feat(build): add windows builds to Travis Oct 24, 2018
@moorereason
Copy link
Contributor Author

It looks like most of the "advanced" stuff in the Makefile may be a problem for Travis windows builds. I stripped a lot of that out to get it to build.

@xcoulon
Copy link
Member

xcoulon commented Oct 24, 2018

It looks like most of the "advanced" stuff in the Makefile may be a problem for Travis windows builds. I stripped a lot of that out to get it to build.

Ok, I understand. Well, this makes the whole "build" much simpler, in the end, so it's even better :)
At this point, I believe we should add support for macos (osx), too.

Please remove the WIP prefix on the PR title once you feel it's good to merge.

.travis.yml Outdated Show resolved Hide resolved
@moorereason moorereason changed the title WIP feat(build): add windows builds to Travis feat(build): add windows and osx builds to Travis Oct 26, 2018
@moorereason
Copy link
Contributor Author

I rebased this PR to clean up the git log. I'll update the OP to match the extended scope since we're adding OSX, too.

@xcoulon
Copy link
Member

xcoulon commented Oct 26, 2018

thanks for this PR, @moorereason ! The Makefile and the .travis.yml config file are now much simpler and having all platforms build on a single place is nice ;)

@xcoulon xcoulon merged commit 94a8009 into bytesparadise:master Oct 26, 2018
@moorereason moorereason deleted the iss223 branch October 30, 2018 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants