feat(parser/renderer): support inline footnotes #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support for `footnote` and `footnoteref` macros also, rename `Content` to `Elements` in `Section` type. Fixes bytesparadise#139 Signed-off-by: Xavier Coulon <[email protected]>
golangcibot
reviewed
Sep 15, 2018
| } | ||
| c := types.NewFootnotesCollector() | ||
| // when | ||
| content.Accept(c) |
There was a problem hiding this comment.
Error return value of content.Accept is not checked
| } | ||
| c := types.NewFootnotesCollector() | ||
| // when | ||
| content.Accept(c) |
There was a problem hiding this comment.
Error return value of content.Accept is not checked
pkg/types/grammar_types.go
Outdated
| xrefsCollector := NewElementReferencesCollector() | ||
| for _, e := range elements { | ||
| if v, ok := e.(Visitable); ok { | ||
| v.Accept(xrefsCollector) |
There was a problem hiding this comment.
Error return value of v.Accept is not checked
pkg/types/grammar_types.go
Outdated
| if v, ok := e.(Visitable); ok { | ||
| v.Accept(c) | ||
| v.Accept(footnotesCollector) |
There was a problem hiding this comment.
Error return value of v.Accept is not checked
Signed-off-by: Xavier Coulon <[email protected]>
Signed-off-by: Xavier Coulon <[email protected]>
Signed-off-by: Xavier Coulon <[email protected]>
xcoulon
added a commit
that referenced
this pull request
Sep 15, 2018
support for `footnote` and `footnoteref` macros also, rename `Content` to `Elements` in `Section` type. Fixes #138 Signed-off-by: Xavier Coulon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support for
footnoteandfootnoterefmacrosalso, rename
ContenttoElementsinSectiontype.Fixes #139
Signed-off-by: Xavier Coulon [email protected]