feat(parser/renderer): support role attributes, refactor attributes and image type #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangci
reviewed
Aug 22, 2018
pkg/renderer/html5/renderer.go
Outdated
| @@ -225,6 +225,21 @@ func getID(attributes map[string]interface{}) string { | |||
| return id | |||
| } | |||
|
|
|||
| // hasRole checks if the given map has an entry with key `types.AttrRole` | |||
| func hasRole(attributes map[string]interface{}) bool { | |||
pkg/renderer/html5/renderer.go
Outdated
| } | ||
|
|
||
| // getRole returns the value for the entry with key `types.AttrRole` in the given map | ||
| func getRole(attributes map[string]interface{}) string { |
pkg/types/grammar_types.go
Outdated
| // log.Debugf("initializing a new AttributeGroup with %v", attributes) | ||
| result := make(map[string]interface{}, 0) | ||
| result := make(ElementAttributes, 0) |
There was a problem hiding this comment.
should use make(ElementAttributes) instead
xcoulon
force-pushed
the
Issue151_support_attributes
branch
from
f8a2c21 to
6446ca9
Compare
…nd image type
While improving support for role, id and title in the lists, this patch
also introduces changes in the attributes which get their own type
instead of `map[string]interface{}`, which allows for utility method(s).
Also, pursuing on images, the `Macro` type that is common to `BlockImage`
and `InlineImage` is behind removed, to avoid having to deal with 2 levels
of attributes for the same element.
Fixes bytesparadise#151
Signed-off-by: Xavier Coulon <[email protected]>
xcoulon
force-pushed
the
Issue151_support_attributes
branch
from
6446ca9 to
0a02da5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While improving support for role, id and title in the lists, this patch
also introduces changes in the attributes which get their own type
instead of
map[string]interface{}, which allows for utility method(s).Also, pursuing on images, the
Macrotype that is common toBlockImageand
InlineImageis behind removed, to avoid having to deal with 2 levelsof attributes for the same element.
Fixes #151
Signed-off-by: Xavier Coulon [email protected]