From adb5d34437d1194dd534c7130ecac248cee0141c Mon Sep 17 00:00:00 2001 From: Nick Fitzgerald Date: Thu, 12 Oct 2023 09:01:17 -0700 Subject: [PATCH] Don't verify wasm-encoder and wasmparser publishes because of circular dev dep --- ci/publish.rs | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/ci/publish.rs b/ci/publish.rs index 756fdac0a9..c54adcc648 100644 --- a/ci/publish.rs +++ b/ci/publish.rs @@ -43,6 +43,12 @@ const CRATES_TO_PUBLISH: &[&str] = &[ "wasm-tools", ]; +const NO_VERIFY: &[&str] = &[ + // Circular dev dependencies between `wasmparser` and `wasm-encoder`. + "wasm-encoder", + "wasmparser", +]; + #[derive(Clone)] struct Crate { manifest: PathBuf, @@ -327,11 +333,15 @@ fn publish(krate: &Crate) -> bool { return true; } - let status = Command::new("cargo") - .arg("publish") - .current_dir(krate.manifest.parent().unwrap()) - .status() - .expect("failed to run cargo"); + let mut cmd = Command::new("cargo"); + cmd.arg("publish"); + cmd.current_dir(krate.manifest.parent().unwrap()); + + if NO_VERIFY.iter().any(|s| *s == krate.name) { + cmd.arg("--no-verify"); + } + + let status = cmd.status().expect("failed to run cargo"); if !status.success() { println!("FAIL: failed to publish `{}`: {}", krate.name, status); return false;