Fix WASI Path Mapping Processing #3923
Open
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpjohnst
requested review from
loganek,
lum1n0us,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
Filesystem paths can be mapped from the host path to a guest path using the format `<guest-path>::<host-path>`. Previously `strtok` was used to find the `::` delimiter. Unfortunately `strtok` processes each delimiter character individually. This meant that the code was ~equivalent to `strtok(mapping_copy, ":")` which breaks with Windows-style paths (E.g. `C:\my_path\`). To fix this `strstr` is used to search for the exact delimiter.
dpjohnst
force-pushed
the
fix-wasi-path-mapping
branch
from
2d36ca6
to
25512f3
Compare
lum1n0us
reviewed
Nov 22, 2024
wenyongh
reviewed
Nov 23, 2024
| if (delim_pos) { | ||
| *delim_pos = '\0'; | ||
| map_mapped = mapping_copy; | ||
| map_host = delim_pos + strlen(delim); |
There was a problem hiding this comment.
map_host may be an empty string "", do you think we should check whether strlen(map_host) == 0, and if yes, set map_host to NULL to let runtime report error and exit?
wenyongh
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filesystem paths can be mapped from the host path to a guest path using the format
<guest-path>::<host-path>.Previously
strtokwas used to find the::delimiter. Unfortunatelystrtokprocesses each delimiter character individually. This meant that the code was ~equivalent tostrtok(mapping_copy, ":")which breaks with Windows-style paths (E.g.C:\my_path\).To fix this
strstris used to search for the exact delimiter.