Improve strict-provenance compatibility in the epoll API.
#693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
force-pushed
the
sunfishcode/epoll-provenance
branch
3 times, most recently
from
9ea1a84 to
60a117e
Compare
sunfishcode
added
the
semver bump
|
There's a FIXME here; once #615 lands, I'll replace the FIXME comment with tests that |
sunfishcode
force-pushed
the
sunfishcode/epoll-provenance
branch
from
60a117e to
caf5871
Compare
Change the user-data field of epoll's `Event` from a bare `u64` to a `union` which can be either a `u64` or a `*mut c_void` to allowe users to store pointers in it that preserve strict provenance. Also, rename `epoll::epoll_add` and similar to just `epoll::add` and similar, for tidiness.
sunfishcode
force-pushed
the
sunfishcode/epoll-provenance
branch
from
caf5871 to
83eff17
Compare
|
FIXME is now fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the user-data field of epoll's
Eventfrom a bareu64to aunionwhich can be either au64or a*mut c_voidto allowe users to store pointers in it that preserve strict provenance.Also, rename
epoll::epoll_addand similar to justepoll::addand similar, for tidiness.