forked from mozilla/gecko-dev
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to spidermonkey 115 #7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4852cc8.
This reverts commit 15d6982.
…ream and PipeTo r=jandem" This reverts commit f83d513.
…acy prefs. r=mgaudet,webidl,edgar" This reverts commit c256578.
This reverts commit 75cea93.
This reverts commit b54b833.
… r=iain" This reverts commit d1c4d10.
This reverts commit f81ba5c.
…of r=iain" This reverts commit 557de26.
…rototype The flag was previously only respected for internal builtins, not classes defined by the embedding using `JS_InitClass`. That meant one couldn't use `JS_InitClass` to define classes without a globally available constructor.
This got lost when fdlibm was re-vendored, because the fix wasn't created as a patch in `modules/fdlibm/patches`. Upstreaming this change will require adding that patch file.
In long-running environments, it's desirable for the embedding to reset the random seed at controlled points in time. In particular, when running in WASI, a situation can occur where a VM snapshot is taken at build time using [Wizer](https://github.com/bytecodealliance/wizer), which is then loaded and used as the basis for running separate workloads many times over. If `Math.random()` was called during the initialization phase, this would cause all workloads to get the same results for all consecutive calls to `Math.random()`.
This adds a few functions for working with ReadableStream, plus introduces a basic set of ones for working with WritableStreams at all. This patch also includes updates to some of the doc comments for the existing streams API: for many functions the doc comment said that they assert that a passed `Handle<JSObject*>` is (a wrapper for) a specific type, but in reality the function does a check and throws an error instead of asserting. Since this patch introduces a few functions that actually do assert, it seems important to ensure the different behavior is correctly documented.
… actions get queued that trigger a pipeTo shutdown This can happen e.g. when closing the readable and then erroring the writable end of the pipe in the same microtask. The Streams spec guards against this by just making Shutdown and ShutdownWithAction bail early if already shutting down, but the implementation was doing an upwrap of the source or destination stream that fails if not guarded by a shuttingDown check because the streams have already been cleared.
… pending write requests when the source is closed
Co-authored-by: Jake Champion <[email protected]>
JakeChampion
force-pushed
the
jake/jff-115
branch
from
July 20, 2023 13:00
9eef924
to
6e34b2f
Compare
JakeChampion
force-pushed
the
fastly/ff-115
branch
from
July 20, 2023 15:07
85d52b3
to
c1236bb
Compare
JakeChampion
force-pushed
the
jake/jff-115
branch
from
July 20, 2023 15:10
2097137
to
6e34b2f
Compare
elliottt
reviewed
Jul 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you need to make any changes to the patch set when rebasing on 115?
elliottt
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed in a DM that no changes to the patches were necessary 👍
JakeChampion
added a commit
to fastly/spidermonkey-wasi-embedding
that referenced
this pull request
Jul 21, 2023
Dependent upon bytecodealliance/gecko-dev#7 landing
JakeChampion
pushed a commit
that referenced
this pull request
Aug 30, 2023
We already cherry-picked this when we vendored 151be743d4. Upstream commit: https://webrtc.googlesource.com/src/+/2abe6e2214fa4fcecdb9614715c55a82c0067e25 [M115] Bail out early if the RTP send module for a SSRC was not found since it might have been deregistered previously. BUG=chromium:1454860,chromium:1459124 (cherry picked from commit c0ed83eac258032a2416b7e4200bd074a6455f4b) Change-Id: I70ba43265361d040e568f83b6400ff8f3c2a8e98 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/311800 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Philipp Hancke <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#40431} Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/312121 Cr-Commit-Position: refs/branch-heads/5790@{#7} Cr-Branched-From: 2eacbbc03a4a41ea658661225eb1c8fc07884c33-refs/heads/main@{#40122}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.