Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to spidermonkey 115 #7

Merged
merged 21 commits into from
Jul 21, 2023
Merged

Update to spidermonkey 115 #7

merged 21 commits into from
Jul 21, 2023

Conversation

JakeChampion
Copy link
Collaborator

No description provided.

elliottt and others added 21 commits July 20, 2023 13:59
…acy prefs. r=mgaudet,webidl,edgar"

This reverts commit c256578.
…rototype

The flag was previously only respected for internal builtins, not classes defined by the embedding using `JS_InitClass`. That meant one couldn't use `JS_InitClass` to define classes without a globally available constructor.
This got lost when fdlibm was re-vendored, because the fix wasn't created as a patch in `modules/fdlibm/patches`. Upstreaming this change will require adding that patch file.
In long-running environments, it's desirable for the embedding to reset the random seed at controlled points in time.

In particular, when running in WASI, a situation can occur where a VM snapshot is taken at build time using [Wizer](https://github.com/bytecodealliance/wizer), which is then loaded and used as the basis for running separate workloads many times over. If `Math.random()` was called during the initialization phase, this would cause all workloads to get the same results for all consecutive calls to `Math.random()`.
This adds a few functions for working with ReadableStream, plus introduces a basic set of ones for working with WritableStreams at all.

This patch also includes updates to some of the doc comments for the existing streams API: for many functions the doc comment said that they assert that a passed `Handle<JSObject*>` is (a wrapper for) a specific type, but in reality the function does a check and throws an error instead of asserting. Since this patch introduces a few functions that actually do assert, it seems important to ensure the different behavior is correctly documented.
… actions get queued that trigger a pipeTo shutdown

This can happen e.g. when closing the readable and then erroring the writable end of the pipe in the same microtask.

The Streams spec guards against this by just making Shutdown and ShutdownWithAction bail early if already shutting down, but the implementation was doing an upwrap of the source or destination stream that fails if not guarded by a shuttingDown check because the streams have already been cleared.
… pending write requests when the source is closed
Co-authored-by: Jake Champion <[email protected]>
@JakeChampion JakeChampion requested a review from elliottt July 21, 2023 00:28
@JakeChampion JakeChampion marked this pull request as ready for review July 21, 2023 00:28
Copy link
Member

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you need to make any changes to the patch set when rebasing on 115?

Copy link
Member

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed in a DM that no changes to the patches were necessary 👍

@JakeChampion JakeChampion merged commit 8bdf2ff into fastly/ff-115 Jul 21, 2023
@JakeChampion JakeChampion deleted the jake/jff-115 branch July 21, 2023 17:14
JakeChampion added a commit to fastly/spidermonkey-wasi-embedding that referenced this pull request Jul 21, 2023
JakeChampion pushed a commit that referenced this pull request Aug 30, 2023
We already cherry-picked this when we vendored 151be743d4.

Upstream commit: https://webrtc.googlesource.com/src/+/2abe6e2214fa4fcecdb9614715c55a82c0067e25
    [M115] Bail out early if the RTP send module for a SSRC was not found

    since it might have been deregistered previously.

    BUG=chromium:1454860,chromium:1459124

    (cherry picked from commit c0ed83eac258032a2416b7e4200bd074a6455f4b)

    Change-Id: I70ba43265361d040e568f83b6400ff8f3c2a8e98
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/311800
    Reviewed-by: Harald Alvestrand <[email protected]>
    Commit-Queue: Philipp Hancke <[email protected]>
    Cr-Original-Commit-Position: refs/heads/main@{#40431}
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/312121
    Cr-Commit-Position: refs/branch-heads/5790@{#7}
    Cr-Branched-From: 2eacbbc03a4a41ea658661225eb1c8fc07884c33-refs/heads/main@{#40122}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants