fix: cleanup storage and serializer implementation #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amokfa
force-pushed
the
serializer-storage-cleanup
branch
4 times, most recently
from
c385ddf to
5d39851
Compare
* Add documentation * Fixed miscellaneous bugs
* use max_packet_size properly * directory storage bugfix
* delete duplicate test
* Add saving and reloading for serializer * handle in transit packets properly in serializer
…live data for all the streams is pushed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress PR.
Closes #
SHIP-48
SHIP-56
SHIP-57
SHIP-58
SHIP-59
Changes
Why?
Serialization related code was hard to follow and understand. This PR adds a disk backed queue interface in serializer/storage.rs to improve readability.
Trials Performed