-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support publishing #45
Comments
Braindump: Reading the Publishing documentation there are certain keys that require a rebuild of the native side. It might be a stretch goal for this to automatically kick of an actual build or warning or something when an native build is required. |
Hi Matt! Great feature request! Let's get this in 😄 And thanks for the link where you use it, it's always fun to see it in action. 👍 Ok, so let's break it down into multiple steps. First, we need to add the How do you feel about this?
If you want to get some work done already, feel free to do so! I'll try to make some time available too for this. I can't tell when yet, but I'll keep you posted! Again, thanks for the awesome suggestion! ❤️ |
Adding I was thinking the On board with adding the stretch goals later, the MVP for this is essentially run |
Description of the feature
During the
publish
step the plugin could automatically perform aexpo-cli publish
. It would only do this if the environment was correctly verified duringverifyConditions
Motivation
It would be really handy to have builds published automatically to Expo as part of the semantic-release workflow.
Additional context
It would be really cool if you could add rules to determine the channel that the release is published to. Not really sure how we could do that. There is semantic-release/semantic-release#563 for supporting channels for NPM packages, so would probably make sense to wait for that to be resolved before we figured out what to do for channels.
For now we could just specify which channel to publish to in the configuration. It could publish by default to the
default
channel (duh) but it would most likely best if it published toalpha
. Then you can manually change the channel for specific version withexpo-cli publish:set -p <id> -c <beta|production>
.I happy to do the leg work getting this feature together if you're keen for it. Currently using this plugin in https://github.com/ef-carbon/react-native-demo
The text was updated successfully, but these errors were encountered: