-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Android/iOS version number configuration #4
Comments
I think we might as well also create this feature for the normal |
@jaulz Thanks for the kind words and good feedback, I really appreciate it! I totally agree with you that versions should be "calculatable" at any time, without depending on the history. The approach from maxirosson sounds really sensible to me, and I really want to support it. Unfortunately, not all the variables used within this approach are available. But I think we can cover it by using other available variables. The For the For the Sorry for the spam/big message. I will make some time available tomorrow to get this feature implemented asap. |
@byCedric great, I like it! I just updated the PR and included the Expo version as well. We can keep the |
Yeah, you are right. We can introduce it later as new feature. For now your PR looks really good, thanks for updating the documentation too! So, let's release this as new major release of the package. Tomorrow I will try and get a first draft of the templating part started. If this templating is finished, I will default it on Android to the value you are currently calculating (to ensure a smooth transition, without breaking stuff). |
Nice :) Looking forward for the templates! Let me know if you need help. |
@jaulz Your PR was really good, didn't require any big change and I got excited. So it's live in |
Quick update, I started with the template feature. Unfortunately, due to a major outage with NPM which I'm also affected by, I can't finish the first draft today. I hope to have it by Wednesday! |
My apologies for taking longer than expected. But, the first draft is finally here! I'll resolve the final issues and test it before releasing. If everything goes well, I'll release it straight afterward. |
Works like a charm, I'm releasing |
Released in |
Yeah, thanks a lot, nice work 😊 |
Detailed description
Right now there is no way to customize a
versionCode
(Android) orbuildNumber
(iOS). Android will be increased with 1 and iOS will use the exact version name, just like the normal version. I'd figure some people want to customize this. It should work a bit like the build-in tag/version functionality. The only still-unsolved-thing is the build numbers from Android. There is currently no way of detecting the exact build number (integer).The text was updated successfully, but these errors were encountered: