Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update library for usage with new manifest format #175

Open
byCedric opened this issue Dec 21, 2019 · 2 comments
Open

Update library for usage with new manifest format #175

byCedric opened this issue Dec 21, 2019 · 2 comments
Labels
feature A new feature request
Milestone
3.0.0

Comments

@byCedric
Copy link
Owner

Description of the feature

Evan is working on some changes related to the manifest format. If this is merged and supported, we need to update this library. It's still pending review, but once it's merged I'll start on it 😄

Motivation

Everything Expo supports, we should implement. 🚀
@byCedric byCedric added the feature A new feature request label Dec 21, 2019
@byCedric byCedric added this to the 3.0.0 milestone Dec 21, 2019
@owentar
Copy link

owentar commented Apr 7, 2020 •
edited
Loading

Hi guys! Seems like part of those changes mentioned above went through into Expo's SDK 37. They basically removed the sdkVersion from the app.json file. Are we planning to put an update for this?

WORK AROUND: add back in the sdkVersion.

@owentar
Copy link

owentar commented Apr 7, 2020 •
edited
Loading

Looking at how to implement this since the sdkVersion is no longer in the app.json. Can we relay on expo-constants as a dependency to get this value (from NativeConstants.manifest.sdkVersion)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature A new feature request
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@byCedric @owentar