From d6cb34eef28fdadaa51112c1f5e4f084689066f7 Mon Sep 17 00:00:00 2001
From: Ian Shim <100327837+ian-shim@users.noreply.github.com>
Date: Wed, 20 Mar 2024 15:59:45 -0700
Subject: [PATCH] Sort quorum IDs before aggregation (#375)

---
 core/aggregation.go          | 2 +-
 disperser/batcher/batcher.go | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/core/aggregation.go b/core/aggregation.go
index cfc4c141bc..f593567154 100644
--- a/core/aggregation.go
+++ b/core/aggregation.go
@@ -149,7 +149,7 @@ func (a *StdSignatureAggregator) AggregateSignatures(ctx context.Context, state
 
 			// If operator is not in quorum, skip
 			if !ok {
-				a.Logger.Error("Operator not found in quorum", "operatorID", operatorIDHex, "operatorAddress", operatorAddr, "socket", socket)
+				a.Logger.Error("Operator not found in quorum", "operatorID", operatorIDHex, "operatorAddress", operatorAddr, "socket", socket, "quorumID", id)
 				continue
 			}
 
diff --git a/disperser/batcher/batcher.go b/disperser/batcher/batcher.go
index 72fb3b663b..4b108f38b7 100644
--- a/disperser/batcher/batcher.go
+++ b/disperser/batcher/batcher.go
@@ -7,6 +7,7 @@ import (
 	"fmt"
 	"math"
 	"math/big"
+	"slices"
 	"time"
 
 	"github.com/Layr-Labs/eigenda/common"
@@ -426,6 +427,7 @@ func (b *Batcher) HandleSingleBatch(ctx context.Context) error {
 	for quorumID := range batch.State.Operators {
 		quorumIDs = append(quorumIDs, quorumID)
 	}
+	slices.Sort(quorumIDs)
 
 	stageTimer = time.Now()
 	aggSig, err := b.Aggregator.AggregateSignatures(ctx, batch.State, quorumIDs, headerHash, update)