-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] List with CellMeasurer does not render correctly #866
Comments
+1. an easy workaround for the cell sizing appears to be to pass in the function form ({ measure }) => ) instead of the actual element to the CellMeasurer and call measure from inside. |
+1 |
1 similar comment
+1 |
@krsnaa Your idea doesn't work either in my project or in the plunkr that steinso posted. +1 for fixing this bug. |
If any of you leaving +1 comments would be interested in contributing a fix for this issue, I'd welcome the help. 😄 |
@bvaughn I'd be happy to try and fix this! |
I'd welcome a fix, @OriR! I don't really have anything to point you at though, other than |
Ok then, I'll start digging around and see what I can find :) |
@bvaughn I opened a PR fixing this issue :) |
Yes same problem Grid is not initialized correctly, waiting for fix. Right now i use workaround.
|
I plan to release an update this morning with this fix. |
Has this bug fixed? |
still suffering on this issue. |
Reproducible case: https://plnkr.co/edit/5I4FzHs8juZ4L6m5NKwV?p=preview
When rendering a List with a CellMeasurer (and deferredMeasurementCache) all rows are rendered on top of each other, only when you start to scroll the items are rendered. Also notice how it does not invalidate the dimensions of the initially rendered rows, and they all get the default height. Any rows not initially rendered are measured and rendered correctly.
My initial findings are that the Grid on List is not initialized at the point where cells are measured, therefore the invalidateCellSizeAfterRender is not called.
This was working prior to version 9.10.0.
The text was updated successfully, but these errors were encountered: