Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<localisations> Untranslated password tips&hints #433

Closed
RakotStargazer opened this issue Nov 20, 2017 · 3 comments
Closed

<localisations> Untranslated password tips&hints #433

RakotStargazer opened this issue Nov 20, 2017 · 3 comments

Comments

@RakotStargazer
Copy link
Contributor

There's some untranslated parts in tips&hints, at least when editing an entry all password-related hints are in english regardless of the selected language, pls see screenshots.
Unfortunately I couldn't find these sentences in the code, so I've no idea how to fix it.

2017-11-19_21-14-21
2017-11-20_22-15-16

@perry-mitchell
Copy link
Member

Thanks @RakotStargazer - Good observation.

This has been mentioned in the original localisation PR comments: Basically the password generator and some other components, are external and need separate localisation support. For instance, I've added a task on the generator here. I'll close this issue as it has to do with the other components.

@RakotStargazer
Copy link
Contributor Author

@perry-mitchell don't think these parts related to password generator. PG have it's own pop-up window, and it's untranslated, yes, but the password field tips isn't part of the generator. btw I couldn't find these sentences in ALL the Buttercup's github code (you can try to find the word "Uncommon" for example). It have to be related to some external code that checks if password secure enough. All that I've found today that this is most likely the result from result.feedback.suggestions from buttercup-ui/src/components/meter.js

2017-11-20_23-42-25

@RakotStargazer
Copy link
Contributor Author

aaaaaand finally after some investigation - these tips are from zxcvbn function (https://www.npmjs.com/package/zxcvbn)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants