Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add collateral only when using plutus #3

Merged
merged 2 commits into from
Apr 11, 2024
Merged

add collateral only when using plutus #3

merged 2 commits into from
Apr 11, 2024

Conversation

baymac
Copy link

@baymac baymac commented Apr 10, 2024 •
edited
Loading

@baymac baymac marked this pull request as ready for review April 10, 2024 12:34
@ljttl3q04t
Copy link
Collaborator

ljttl3q04t commented Apr 11, 2024 •
edited
Loading

There are 2 ways to using Plutus in Trans:

  1. collectFrom()
  2. attachScript()
    So just need to check this.scripts to verify Tx using Plutus

@ljttl3q04t ljttl3q04t requested a review from h2physics April 11, 2024 03:45
@h2physics
Copy link
Member

@ljttl3q04t The approach of @ljttl3q04t still has some edge cases but it's acceptable during this phase.

@h2physics h2physics merged commit 5303d25 into minswap Apr 11, 2024
1 check failed
@h2physics h2physics deleted the is-using-plutus branch April 11, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h2physics h2physics h2physics approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collateral is set unnecessarily
3 participants
@baymac @ljttl3q04t @h2physics